- r65468: 2010-09-04 13:33:40 [VZ] Vadim Zeitlin
-
/src/msw/progdlg.cpp [diff, log, file]
Remove unused wxProgressDialogTaskRunner::m_parent field.
This seems to be a left over from old version of the code and is not used any
longer.
See #12414.
- r65467: 2010-09-04 13:33:36 [VZ] Vadim Zeitlin
-
/src/msw/progdlg.cpp [diff, log, file]
Fix crash in wxMSW wxProgressDialog without wxPD_APP_MODAL style.
Use the correct method to retrieve the parent window to disable and check that
this pointer is not NULL before dereferencing it.
Closes #12414.
- r65466: 2010-09-04 13:33:29 [VZ] Vadim Zeitlin
-
/src/msw/msgdlg.cpp [diff, log, file]
Improve main and extended messages handling in new wxMSW wxMessageDialog.
Don't use the main message if there is no extended message: this looks bad as
the main message is emphasized to contrast with the extended one which doesn't
make sense visually if there is no extended message.
Also recognize the common use of wxMessageBox() with a multiline text composed
of the first string that plays the role of the main message with the rest
being the extended one and handle this appropriately automatically. This
results in a better appearance by default for a lot of message boxes,
including even the one in our own minimal sample.
- r65465: 2010-09-04 09:36:25 [VZ] Vadim Zeitlin
-
/interface/wx/msgdlg.h [diff, log, file]
Add a link to Microsoft guidelines from wxICON_QUESTION documentation.
Microsoft documentation provides explanations as to how the icons should be
used in the message dialogs which can be useful for people wondering which
icon style to use an when.
See #12417.
- r65464: 2010-09-03 22:48:44 [VZ] Vadim Zeitlin
-
/configure [diff, log, file]
/configure.in [diff, log, file]
Don't link with long obsolete ctl3d32 library when using MinGW.
ctl3d32 was used for Win16 development and is not used by wxMSW since many
years, don't link with it unnecessarily when using MinGW.
Also remove a FIXME comment about an issue which doesn't seem to need any
fixing.
- r65453: 2010-09-01 09:48:24 [VZ] Vadim Zeitlin
-
/build/msw/wx_dll.dsw [diff, log, file]
Update wx_dll.dsw to include the ribbon library.
Add wx_ribbon project with dependency on core library.
- r65451: 2010-08-30 22:18:52 [VZ] Vadim Zeitlin
-
/include/wx/generic/grid.h [diff, log, file]
/interface/wx/grid.h [diff, log, file]
/src/generic/grid.cpp [diff, log, file]
Add wxGrid::RefreshAttr() method to force attribute refresh.
A cached attribute may continue to be used even though the attribute returned
by a custom wxGridCellAttrProvider has changed so add a method to force wxGrid
to update the attribute by forgetting the cached copy.
Closes #12406.
- r65450: 2010-08-30 21:48:25 [VZ] Vadim Zeitlin
-
/src/generic/msgdlgg.cpp [diff, log, file]
Don't center wxGenericMessageDialog elements.
Centering doesn't seem to be appropriate on neither of the major platforms and
makes wxGenericMessageDialog and wxGenericRichMessageDialog which uses it look
even less native than otherwise.
Simply don't do it neither for the text nor, especially, for the buttons where
wxStdDialogButtonSizer already exists to take care of their alignment.
- r65449: 2010-08-30 21:48:21 [VZ] Vadim Zeitlin
-
/include/wx/generic/msgdlgg.h [diff, log, file]
/include/wx/msgdlg.h [diff, log, file]
/src/generic/msgdlgg.cpp [diff, log, file]
Allow using custom labels for wxGenericMessageDialog buttons.
Custom labels set for wxGenericMessageDialog buttons were simply ignored as it
used CreateSeparatedButtonSizer() to create the actual buttons which in turn
always used the standard labels.
Fix this by explicitly creating the buttons with custom labels if necessary.
This also fixes custom label support in wxGenericRichMessageDialog deriving
from this class.
- r65448: 2010-08-30 21:48:16 [VZ] Vadim Zeitlin
-
/include/wx/dialog.h [diff, log, file]
/interface/wx/dialog.h [diff, log, file]
/src/common/dlgcmn.cpp [diff, log, file]
Extract CreateSeparatedSizer() from wxDialog::CreateSeparatedButtonSizer().
Extract the code adding a separating wxStaticLine to the sizer in its own
function to be able to reuse it in upcoming commits.
- r65447: 2010-08-30 21:48:11 [VZ] Vadim Zeitlin
-
/src/common/sizer.cpp [diff, log, file]
Fix button order in wxStdDialogButtonSizer in all cases under GTK.
The order of Yes/No/Cancel was recently fixed by the changes in r65346 but it
broke the order of the buttons in Ok/Cancel case. Ensure the correct order is
used in all cases now: the one described by GNOME HIG by default but different
order for the special case of Yes/No/Cancel which follows the native message
box.
- r65446: 2010-08-30 21:48:06 [VZ] Vadim Zeitlin
-
/src/common/sizer.cpp [diff, log, file]
Rewrite GTK section of wxStdDialogButtonSizer using wxSizerFlags.
Using wxSizerFlags makes the code shorter and more understandable but
otherwise there are no real changes in behaviour except for a minor fix to one
of the border which was wrong before.
- r65398: 2010-08-24 11:36:43 [VZ] Vadim Zeitlin
-
/src/msw/display.cpp [diff, log, file]
Remove unused wxDisplay implementation using DirectDraw from wxMSW.
Remove commented out version of DirectDraw-based wxDisplayFactory
implementation. It doesn't seem to have any advantages compared to the
currently used version and nobody uses it anyhow.
Closes #12387.
- r65393: 2010-08-23 18:54:59 [VZ] Vadim Zeitlin
-
/tests/controls/textentrytest.h [diff, log, file]
Compilation fix: forward declare wxTextEntry in unit tests code.
This should fix tests compilation on the build bot Mac OS X slaves.
- r65390: 2010-08-22 23:46:02 [VZ] Vadim Zeitlin
-
/tests/controls/textctrltest.cpp [diff, log, file]
Use "C" locale for locale-dependent part of TextCtrlTestCase.
As we expect to get decimal points in the text control when we stream floating
point numbers into it, we must do it in a locale which uses decimal point,
e.g. "C" one. Otherwise the test failed when ran in e.g. French locale.
- r65389: 2010-08-22 23:45:58 [VZ] Vadim Zeitlin
-
/interface/wx/filedlg.h [diff, log, file]
Document that wxFD_FILE_MUST_EXIST is implied under OS X.
Mention in the documentation that the standard file open dialog under OS X
can't be used to select a non-existing file.
- r65388: 2010-08-22 23:45:53 [VZ] Vadim Zeitlin
-
/build/bakefiles/files.bkl [diff, log, file]
/Makefile.in [diff, log, file]
/src/osx/cocoa/bmpbuttn.mm [old log]
Remove unused src/osx/cocoa/bmpbuttn.mm file.
This file was empty and unused any more so simply remove it and all references
to it in the makefiles.
This avoids warnings about empty object files in static builds of the library.
- r65387: 2010-08-22 22:58:25 [VZ] Vadim Zeitlin
-
/src/osx/uiaction_osx.cpp [diff, log, file]
Don't use uninitialized variable in wxCharCodeWXToOSX().
If an unsupported wxKeyCode was passed to this function, an undefined value
was returned. Return -1 instead to indicate failure.
- r65386: 2010-08-22 22:16:05 [VZ] Vadim Zeitlin
-
Click to show all 79 changes...
Merge the new GUI tests from SOC2010_GUI_TEST branch.
Add a lot of tests for many wx GUI classes.
Add tests using the new wxUIActionSimulator class but disable them under OS X
as too many of them currently fail there.
Refactor the test suite to make organizing the existing tests and adding the
new ones easier.
Improve documentation using the information gathered while testing the
classes. Also update the documentation of the testing system itself.
- r65385: 2010-08-22 22:15:42 [VZ] Vadim Zeitlin
-
Click to show all 22 changes...
Merge wxUIActionSimulator fixes from SOC2010_GUI_TEST branch.
Correct a lot of problems with the initial implementation, notably make the
API consistent across all platforms, e.g. all keyboard-related methods now
take just a wxKeyCode.
Add some useful higher-level helpers such as Text() and MouseDragDrop().
Improve documentation.
wxUIActionSimulator now works under MSW, GTK and OS X and is enabled by
default.
- r65384: 2010-08-22 22:15:32 [VZ] Vadim Zeitlin
-
/src/osx/cocoa/combobox.mm [diff, log, file]
/src/osx/combobox_osx.cpp [diff, log, file]
Fix selection corner cases in wxOSX wxComboBox.
Don't crash in wxComboBox::GetString() if it's passed an invalid index.
Don't call GetString() with invalid index from GetStringSelection() if there
is no selection.
Do accept wxNOT_FOUND in SetSelectedItem() as it means, according to the docs,
that the existing selection should be reset.
- r65383: 2010-08-22 22:15:27 [VZ] Vadim Zeitlin
-
/src/osx/carbon/clipbrd.cpp [diff, log, file]
Don't crash in wxOSX::wxClipboard::Clear() if initialization failed.
Creating the clipboard may fail (e.g. when running from a ssh session to an OS
X machine), don't crash by passing NULL pointer to PasteboardClear() if this
happens but assert and return instead.
- r65382: 2010-08-22 22:15:22 [VZ] Vadim Zeitlin
-
/src/osx/cocoa/window.mm [diff, log, file]
Work around a crash on starting editing in wxGrid under wxOSX/Cocoa.
wxOSX/Cocoa currently generates unexpected focus loss events with the window
gaining focus being the same one as losing it. This is wrong and shouldn't
happen but as long as it does, filter these events out to at least allow
editing the grid to work.
See #12267.
- r65381: 2010-08-22 22:15:17 [VZ] Vadim Zeitlin
-
/interface/wx/listctrl.h [diff, log, file]
/src/msw/listctrl.cpp [diff, log, file]
Don't send event from wxMSW::wxListCtrl::DeleteAllItems() if it did nothing.
wxEVT_COMMAND_LIST_DELETE_ALL_ITEMS should only be sent if the control hadn't
been empty before. Document this behaviour and adjust wxMSW to match the
other platforms.
Also document the return value better.
Closes #12336.
- r65380: 2010-08-22 22:15:13 [VZ] Vadim Zeitlin
-
/include/wx/unix/utilsx11.h [diff, log, file]
/src/gtk/utilsgtk.cpp [diff, log, file]
Extract X11 Display wrapper class in a private header.
No real changes, just extract a private Dpy class used by wxGTK to a header
and rename it to wxX11Display.
This will allow reusing it from X11 wxUIActionSimulator implementation in the
upcoming commits.